build(meson): warn/fail on 32-bit machines #2181
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit Windows, meson setup fails with an unclear error:
meson.build:25:16: ERROR: Could not get define 'CPPHTTPLIB_VERSION'
The actual problem is that httplib.h #errors out.
Have the Meson logic explicitly check for a 32-bit host and warn or error,
matching the check in httplib.h. Phrase the Windows error in a way that
triggers WrapDB CI's unsupported architecture check.
|
@Tachi107 could you please review this pr? Thanks! |
Tachi107
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit Windows,
meson setupfails with an unclear error:The actual problem is that
httplib.h#errors out.Have the Meson logic explicitly check for a 32-bit host and warn or error, matching the check in
httplib.h. Phrase the Windows error in a way that triggers WrapDB CI's unsupported architecture check.